accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request #227: ACCUMULO-4596 Stopped using ACCUMULO_HOME for na...
Date Fri, 03 Mar 2017 17:05:57 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/227#discussion_r104197904
  
    --- Diff: assemble/conf/templates/accumulo-env.sh ---
    @@ -39,9 +39,14 @@ export ZOOKEEPER_HOME="${ZOOKEEPER_HOME:-/path/to/zookeeper}"
     ##################################################################
     
     ## JVM options set for all processes. Extra options can be passed in by setting ACCUMULO_JAVA_OPTS
to an array of options.
    -JAVA_OPTS=("${ACCUMULO_JAVA_OPTS[@]}" '-XX:+UseConcMarkSweepGC' '-XX:CMSInitiatingOccupancyFraction=75'
'-XX:+CMSClassUnloadingEnabled'
    -'-XX:OnOutOfMemoryError=kill -9 %p' '-XX:-OmitStackTraceInFastThrow' '-Djava.net.preferIPv4Stack=true'

    -'-Djavax.xml.parsers.DocumentBuilderFactory=com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderFactoryImpl')
    +JAVA_OPTS=("${ACCUMULO_JAVA_OPTS[@]}" 
    +  '-XX:+UseConcMarkSweepGC'
    +  '-XX:CMSInitiatingOccupancyFraction=75'
    +  '-XX:+CMSClassUnloadingEnabled'
    +  '-XX:OnOutOfMemoryError=kill -9 %p'
    +  '-XX:-OmitStackTraceInFastThrow'
    +  '-Djava.net.preferIPv4Stack=true'
    +  "-Daccumulo.native.lib.dir=${ACCUMULO_HOME}/lib/native")
    --- End diff --
    
    Could make this property a list of dirs, instead of a single dir.  The comment about the
standard directories made me think of `-Daccumulo.native.lib.dirs=${ACCUMULO_HOME}/lib/native:/usr/lib64:/usr/lib`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message