accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request #224: ACCUMULO-4500 ACCUMULO-96 Added summarization
Date Thu, 02 Mar 2017 00:37:30 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/224#discussion_r103826212
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/admin/NewTableConfiguration.java
---
    @@ -121,8 +128,22 @@ public NewTableConfiguration setProperties(Map<String,String>
prop) {
        */
       public NewTableConfiguration enableSampling(SamplerConfiguration samplerConfiguration)
{
         requireNonNull(samplerConfiguration);
    -    SamplerConfigurationImpl.checkDisjoint(properties, samplerConfiguration);
    -    this.samplerConfiguration = samplerConfiguration;
    +    Map<String,String> tmp = new SamplerConfigurationImpl(samplerConfiguration).toTablePropertiesMap();
    +    checkDisjoint(properties, tmp, summarizerProps);
    +    this.samplerProps = tmp;
    --- End diff --
    
    I cleaned this up and simplified it in commit 40ed96f.  That removed the unnecessary checks
and hopefully made it a little more clear.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message