accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request #224: ACCUMULO-4500 ACCUMULO-96 Added summarization
Date Thu, 02 Mar 2017 00:09:52 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/224#discussion_r103822610
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/rfile/RFileWriterBuilder.java
---
    @@ -59,15 +62,22 @@ OutputStream getOutputStream() {
       }
     
       private OutputArgs out;
    -  private SamplerConfiguration sampler = null;
       private Map<String,String> tableConfig = Collections.emptyMap();
       private int visCacheSize = 1000;
    +  private Map<String,String> samplerProps = Collections.emptyMap();
    +  private Map<String,String> summarizerProps = Collections.emptyMap();
    +
    +  private void checkDisjoint(Map<String,String> props, Map<String,String>
sampleProps, Map<String,String> summrizerProps) {
    --- End diff --
    
    That would be the right thing to do.  Its a bit annoying because its private in classes
that in the public API space.  So I would need to place in some third class that not in a
public API package, and I don't know where to put it.  I will added a comment to both methods
mentioning its doppelganger .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message