accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #223: ACCUMULO-4409 Create AccumuloMonitorAppender
Date Wed, 01 Mar 2017 17:23:58 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/223#discussion_r103740195
  
    --- Diff: assemble/conf/log4j.properties ---
    @@ -13,22 +13,24 @@
     # See the License for the specific language governing permissions and
     # limitations under the License.
     
    -# Log4j 1.2 file that configures logging for Accumulo commands
    +## Log4j 1.2 file that configures logging for clients and utility commands
     
    -# Setup console appender
    +## Define a console appender
     log4j.appender.console=org.apache.log4j.ConsoleAppender
    +log4j.appender.console.Target=System.out
    +log4j.appender.console.Threshold=ALL
     log4j.appender.console.layout.ConversionPattern=%d{ISO8601} [%-8c{2}] %-5p: %m%n
     log4j.appender.console.layout=org.apache.log4j.PatternLayout
     
    -# hide AUDIT messages in the shell, alternatively you could send them to a different
logger
    +## Hide audit logs generated by the shell
    --- End diff --
    
    > Not sure why we even have "audit" logs in the shell. This seems non-sensical to me
    
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message