accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #223: ACCUMULO-4409 Create AccumuloMonitorAppender
Date Wed, 01 Mar 2017 16:56:32 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/223#discussion_r103733722
  
    --- Diff: assemble/conf/log4j-service.properties ---
    @@ -13,43 +13,47 @@
     # See the License for the specific language governing permissions and
     # limitations under the License.
     
    -## Log4j 1.2 file that configures logging for all Accumulo services (Master, TabletServer,
GC & Tracer) except Monitor
    +## Log4j 1.2 file that configures logging for all Accumulo services (Master, TabletServer,
GC, and Tracer) except Monitor
     ## The system properties referenced below are configured by accumulo-env.sh
     
    -## Write out INFO and higher to log file
    +## Define a log file appender
     log4j.appender.file=org.apache.log4j.RollingFileAppender
    -log4j.appender.file.File=${accumulo.log.dir}/${accumulo.service.id}.log
    +log4j.appender.file.File=${accumulo.log.dir}/${accumulo.application}.log
     log4j.appender.file.MaxFileSize=100MB
     log4j.appender.file.MaxBackupIndex=10
     log4j.appender.file.Threshold=INFO
     log4j.appender.file.layout=org.apache.log4j.PatternLayout
     log4j.appender.file.layout.ConversionPattern=%d{ISO8601} [%-8c{2}] %-5p: %m%n
     
    -## Forwards Accumulo messages at WARN or higher to Accumulo Monitor
    -log4j.appender.monitor=org.apache.accumulo.start.util.AsyncSocketAppender
    -log4j.appender.monitor.RemoteHost=${accumulo.monitor.host}
    -log4j.appender.monitor.Port=${accumulo.monitor.log.port}
    -log4j.appender.monitor.Application=${accumulo.service.id}
    +## Define an appender to send important logs to the the primary Accumulo Monitor
    +## The primary monitor is the one currently holding a shared lock in ZooKeeper,
    +## and is typically the one that started first.
    +log4j.appender.monitor=org.apache.accumulo.monitor.util.AccumuloMonitorAppender
     log4j.appender.monitor.Threshold=WARN
     
    -## Configures Audit logs which are OFF by default.
    +## Uncomment to define a log file appender for audit logs
     #log4j.appender.audit=org.apache.log4j.DailyRollingFileAppender
    -#log4j.appender.audit.File=${accumulo.log.dir}/${accumulo.audit.log}
    +#log4j.appender.audit.File=${accumulo.log.dir}/${accumulo.application}.audit
    --- End diff --
    
    Yeah, it's just an example, though. I was mostly trying to minimize the number of system
properties we were creating and using for the log4j config. We've already changed the name
of the audit named logger, so its already a change in behavior. I think separating things
out will help users track access to the various services. At this point, we've made it so
users can easily do something different if they wish.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message