accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #224: ACCUMULO-4500 ACCUMULO-96 Added summarization
Date Wed, 01 Mar 2017 16:49:58 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/224#discussion_r103723011
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/admin/SummaryRetriever.java
---
    @@ -0,0 +1,107 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.accumulo.core.client.admin;
    +
    +import java.util.Collection;
    +import java.util.List;
    +
    +import org.apache.accumulo.core.client.AccumuloException;
    +import org.apache.accumulo.core.client.AccumuloSecurityException;
    +import org.apache.accumulo.core.client.TableNotFoundException;
    +import org.apache.accumulo.core.client.summary.SummarizerConfiguration;
    +import org.apache.accumulo.core.client.summary.Summary;
    +import org.apache.hadoop.io.Text;
    +
    +/**
    + * This interface allows configuring where and which summary data to retrieve before
retrieving it.
    + *
    + * @since 2.0.0
    + */
    +public interface SummaryRetriever {
    +
    +  /**
    +   * Summary data is only retrieved from data that has been written to files. Data recently
written to Accumulo may be in memory and there will not show up in
    +   * summary data. Setting this option to true force tablets in the range to minor compact
before summary data is retrieved. By default the table will not be
    +   * flushed before retrieving summary data.
    +   *
    +   * @return this
    +   */
    +  SummaryRetriever flush(boolean shouldFlush);
    +
    +  /**
    +   * Allows optionally setting start row before retrieving data. The start row is not
inclusive.
    --- End diff --
    
    Nit: Move "optionally" to it's own sentence (e.g. "The start row is not inclusive. Calling
this method is optional.") or lead with it (e.g. "Optional, allows setting a start row").
    
    Same applies to the other methods.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message