accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #224: ACCUMULO-4500 ACCUMULO-96 Added summarization
Date Wed, 01 Mar 2017 16:49:38 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/224#discussion_r103721572
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/admin/NewTableConfiguration.java
---
    @@ -121,8 +128,22 @@ public NewTableConfiguration setProperties(Map<String,String>
prop) {
        */
       public NewTableConfiguration enableSampling(SamplerConfiguration samplerConfiguration)
{
         requireNonNull(samplerConfiguration);
    -    SamplerConfigurationImpl.checkDisjoint(properties, samplerConfiguration);
    -    this.samplerConfiguration = samplerConfiguration;
    +    Map<String,String> tmp = new SamplerConfigurationImpl(samplerConfiguration).toTablePropertiesMap();
    +    checkDisjoint(properties, tmp, summarizerProps);
    +    this.samplerProps = tmp;
    --- End diff --
    
    Seems odd to be checking disjoint with `summarizerProps` but then updating `samplerProps`
instead. Maybe javadoc on those member variables would help describe what they each hold.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message