Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: mikewalch <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-221-accumulo@git.apache.org>
In-Reply-To: <git-pr-221-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #221: ACCUMULO-4588 Simplify Accumulo logging configur...
Content-Type: text/plain
Message-Id: <20170224201246.4322FDFAB2@git1-us-west.apache.org>
Date: Fri, 24 Feb 2017 20:12:46 +0000 (UTC)
archived-at: Fri, 24 Feb 2017 20:12:48 -0000

Github user mikewalch commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/221#discussion_r103023673
  
    --- Diff: test/src/main/java/org/apache/accumulo/test/functional/MonitorLoggingIT.java ---
    @@ -1,121 +0,0 @@
    -/*
    - * Licensed to the Apache Software Foundation (ASF) under one or more
    - * contributor license agreements.  See the NOTICE file distributed with
    - * this work for additional information regarding copyright ownership.
    - * The ASF licenses this file to You under the Apache License, Version 2.0
    - * (the "License"); you may not use this file except in compliance with
    - * the License.  You may obtain a copy of the License at
    - *
    - *     http://www.apache.org/licenses/LICENSE-2.0
    - *
    - * Unless required by applicable law or agreed to in writing, software
    - * distributed under the License is distributed on an "AS IS" BASIS,
    - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    - * See the License for the specific language governing permissions and
    - * limitations under the License.
    - */
    -package org.apache.accumulo.test.functional;
    -
    -import static org.junit.Assert.assertNotNull;
    -import static org.junit.Assert.assertTrue;
    -
    -import java.io.File;
    -import java.net.URL;
    -
    -import org.apache.accumulo.core.client.Connector;
    -import org.apache.accumulo.core.client.IteratorSetting;
    -import org.apache.accumulo.core.client.Scanner;
    -import org.apache.accumulo.core.security.Authorizations;
    -import org.apache.accumulo.minicluster.impl.MiniAccumuloConfigImpl;
    -import org.apache.accumulo.monitor.Monitor;
    -import org.apache.accumulo.server.util.Admin;
    -import org.apache.commons.io.FileUtils;
    -import org.apache.zookeeper.KeeperException;
    -import org.junit.Test;
    -import org.slf4j.Logger;
    -import org.slf4j.LoggerFactory;
    -
    -public class MonitorLoggingIT extends ConfigurableMacBase {
    --- End diff --
    
    I answered this in previous comment.
    
    > One open-ended question: how can we make sure that log-forwarding works with the removal of MonitorLoggingIT? Do we need to extend MAC to allow us to configure log4j better and test this?
    
    I thought about this as it would be nice to have to a test that verifies that log forwarding works. The problem is that a lot of the configuration for log forwarding happens in log4j configuration files and accumulo-env.sh. MAC would need set up logging differently which kinds of mitigates the benefits of the test as things could break and the test wouldn't catch it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---