Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: ctubbsii <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-218-accumulo@git.apache.org>
In-Reply-To: <git-pr-218-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #218: ACCUMULO-4528 Accumulo scripts improvements
Content-Type: text/plain
Message-Id: <20170215203721.BCC7EDFC31@git1-us-west.apache.org>
Date: Wed, 15 Feb 2017 20:37:21 +0000 (UTC)
archived-at: Wed, 15 Feb 2017 20:37:23 -0000

Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/218#discussion_r101365517
  
    --- Diff: assemble/conf/examples/generic_logger.properties ---
    @@ -24,7 +24,7 @@ log4j.appender.A2.layout.ConversionPattern=%d{ISO8601} [%-8c{2}] %-5p: %m%n
     
     # Write out INFO and higher to the regular log
     log4j.appender.A3=org.apache.log4j.RollingFileAppender
    -log4j.appender.A3.File=${org.apache.accumulo.core.dir.log}/${org.apache.accumulo.core.application}_${accumulo.service.instance}${org.apache.accumulo.core.ip.localhost.hostname}_fromprops.log
    +log4j.appender.A3.File=${org.apache.accumulo.core.dir.log}/${org.apache.accumulo.core.application}${accumulo.service.instance}_${org.apache.accumulo.core.ip.localhost.hostname}_fromprops.log
    --- End diff --
    
    Maybe we shouldn't enable the rolling file appender in the default configs. Users can add that if they want to. A better option would probably be to use the syslog appender by default.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---