Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: keith-turner <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-210-accumulo@git.apache.org>
In-Reply-To: <git-pr-210-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #210: ACCUMULO-4577: modified exception thrown by Tabl...
Content-Type: text/plain
Message-Id: <20170202181502.16C41F16C7@git1-us-west.apache.org>
Date: Thu,  2 Feb 2017 18:15:02 +0000 (UTC)
archived-at: Thu, 02 Feb 2017 18:15:04 -0000

Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/210#discussion_r99183288
  
    --- Diff: server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java ---
    @@ -171,7 +171,12 @@ public String invalidMessage(String argument) {
             });
     
             String tableId = ClientServiceHandler.checkTableId(master.getInstance(), oldTableName, tableOp);
    -        String namespaceId = Tables.getNamespaceId(master.getInstance(), tableId);
    +        String namespaceId;
    --- End diff --
    
    Could put these 5 lines in a method.  Also, I am thinking it should use NOT_FOUND instead of NAMEPSACE_NOTFOUND.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---