accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #219: ACCUMULO-4584 Remove oneway method checks
Date Wed, 22 Feb 2017 05:24:52 GMT
GitHub user ctubbsii opened a pull request:

    https://github.com/apache/accumulo/pull/219

    ACCUMULO-4584 Remove oneway method checks

    Remove the unnecessary oneway method checking in RpcWrapper (no longer
    needed with Thrift 0.10.0) and simplify RpcWrapper.
    
    Provide more comprehensive test of RpcWrapper behavior with in-memory
    transport to test for exception handling behavior in regular and oneway
    thrift service methods.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ctubbsii/accumulo ACCUMULO-4584-oneway-checks-removal

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/219.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #219
    
----
commit a99b23764b3dd15fa0e3b64ef39e2440cc3e081b
Author: Christopher Tubbs <ctubbsii@apache.org>
Date:   2017-02-22T05:23:03Z

    ACCUMULO-4584 Remove oneway method checks
    
    Remove the unnecessary oneway method checking in RpcWrapper (no longer
    needed with Thrift 0.10.0) and simplify RpcWrapper.
    
    Provide more comprehensive test of RpcWrapper behavior with in-memory
    transport to test for exception handling behavior in regular and oneway
    thrift service methods.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message