accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <>
Subject [GitHub] accumulo pull request #221: ACCUMULO-4588 Simplify Accumulo logging configur...
Date Mon, 27 Feb 2017 21:50:35 GMT
Github user ctubbsii commented on a diff in the pull request:
    --- Diff: test/src/main/java/org/apache/accumulo/test/functional/
    @@ -1,121 +0,0 @@
    - * Licensed to the Apache Software Foundation (ASF) under one or more
    - * contributor license agreements.  See the NOTICE file distributed with
    - * this work for additional information regarding copyright ownership.
    - * The ASF licenses this file to You under the Apache License, Version 2.0
    - * (the "License"); you may not use this file except in compliance with
    - * the License.  You may obtain a copy of the License at
    - *
    - *
    - *
    - * Unless required by applicable law or agreed to in writing, software
    - * distributed under the License is distributed on an "AS IS" BASIS,
    - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    - * See the License for the specific language governing permissions and
    - * limitations under the License.
    - */
    -package org.apache.accumulo.test.functional;
    -import static org.junit.Assert.assertNotNull;
    -import static org.junit.Assert.assertTrue;
    -import org.apache.accumulo.core.client.Connector;
    -import org.apache.accumulo.core.client.IteratorSetting;
    -import org.apache.accumulo.core.client.Scanner;
    -import org.apache.accumulo.minicluster.impl.MiniAccumuloConfigImpl;
    -import org.apache.accumulo.monitor.Monitor;
    -import org.apache.accumulo.server.util.Admin;
    -import org.apache.zookeeper.KeeperException;
    -import org.junit.Test;
    -import org.slf4j.Logger;
    -import org.slf4j.LoggerFactory;
    -public class MonitorLoggingIT extends ConfigurableMacBase {
    --- End diff --
    I don't mind reintroducing it for my purposes, if necessary. I just was hoping for a better
explanation of which MAC setup details made it not useful. Like... which specific line of
code, side-effect, classpath pollution, command-line construction, conflicting design goals,
    If it's too hard to explain, don't worry about it, I can investigate later to figure out
how the test worked and what might have been the issue. It's not important enough to hold
up this review.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message