accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #221: ACCUMULO-4588 Simplify Accumulo logging configur...
Date Fri, 24 Feb 2017 20:15:09 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/221#discussion_r103024088
  
    --- Diff: assemble/conf/templates/accumulo-env.sh ---
    @@ -25,6 +25,21 @@
     # Variables that must be set
     ############################
     
    +## Accumulo logs directory. Referenced by logger config.
    +export ACCUMULO_LOG_DIR="${ACCUMULO_LOG_DIR:-$ACCUMULO_HOME/logs}"
    +## Hadoop installation
    +export HADOOP_PREFIX="${HADOOP_PREFIX:-/path/to/hadoop}"
    +## Hadoop configuration
    +export HADOOP_CONF_DIR="${HADOOP_CONF_DIR:-${HADOOP_PREFIX}/etc/hadoop}"
    +## Zookeeper installation
    +export ZOOKEEPER_HOME="${ZOOKEEPER_HOME:-/path/to/zookeeper}"
    +## See HADOOP-7154 and ACCUMULO-847
    +export MALLOC_ARENA_MAX=${MALLOC_ARENA_MAX:-1}
    --- End diff --
    
    I think leaving it in the environment file was fine. That *was* where the reasonable default
is. I think putting it in the `accumulo` script is inappropriate, as it's not an Accumulo
thing at all, and that basically goes back to what we had before, with config everywhere and
hard to get a handle on "what is the default, and where is the default defined, and what overrides
what?".
    
    It's a JVM thing in some environments. Setting it in the default environment file makes
sense to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message