accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mikewalch <...@git.apache.org>
Subject [GitHub] accumulo pull request #221: ACCUMULO-4588 Simplify Accumulo logging configur...
Date Fri, 24 Feb 2017 18:34:12 GMT
Github user mikewalch commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/221#discussion_r103003156
  
    --- Diff: start/src/test/java/org/apache/accumulo/start/util/AsyncSocketAppenderTest.java
---
    @@ -36,7 +31,7 @@
     
       @Before
       public void setUp() throws Exception {
    -    sa = createMock(SocketAppender.class);
    +    sa = EasyMock.createMock(SocketAppender.class);
    --- End diff --
    
    My IDE was having problems with the static imports.  Not sure why.  I could have looked
into it more but I am not a fan of static imports of methods like that as it makes the code
harder to read.  Therefore, I removed them. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message