accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <>
Subject [GitHub] accumulo pull request #221: ACCUMULO-4588 Simplify Accumulo logging configur...
Date Fri, 24 Feb 2017 18:03:20 GMT
Github user joshelser commented on a diff in the pull request:
    --- Diff: assemble/conf/templates/ ---
    @@ -33,24 +48,22 @@ JAVA_OPTS=("${ACCUMULO_JAVA_OPTS[@]}" '-XX:+UseConcMarkSweepGC' '-XX:CMSInitiati
     ## JVM options set for individual applications
     case "$ACCUMULO_CMD" in
     master)  JAVA_OPTS=("${JAVA_OPTS[@]}" ${masterHigh_masterLow}) ;;
    +monitor) JAVA_OPTS=("${JAVA_OPTS[@]}" ${monitorHigh_monitorLow}) ;;
     gc)      JAVA_OPTS=("${JAVA_OPTS[@]}" ${gcHigh_gcLow}) ;;
     tserver) JAVA_OPTS=("${JAVA_OPTS[@]}" ${tServerHigh_tServerLow}) ;;
    -monitor) JAVA_OPTS=("${JAVA_OPTS[@]}" ${monitorHigh_monitorLow}) ;;
     shell)   JAVA_OPTS=("${JAVA_OPTS[@]}" ${shellHigh_shellLow}) ;;
     *)       JAVA_OPTS=("${JAVA_OPTS[@]}" ${otherHigh_otherLow}) ;;
    -export JAVA_OPTS
    -## Accumulo logs directory. Referenced by logger config.
    -## Hadoop installation
    -export HADOOP_PREFIX="${HADOOP_PREFIX:-/path/to/hadoop}"
    -## Hadoop configuration
    -export HADOOP_CONF_DIR="${HADOOP_CONF_DIR:-${HADOOP_PREFIX}/etc/hadoop}"
    -## Zookeeper installation
    -export ZOOKEEPER_HOME="${ZOOKEEPER_HOME:-/path/to/zookeeper}"
    -## See HADOOP-7154 and ACCUMULO-847
    +## JVM options set for logging
    +JAVA_OPTS=("${JAVA_OPTS[@]}" "-Daccumulo.application=${ACCUMULO_CMD}" "-Daccumulo.log.dir=${ACCUMULO_LOG_DIR}"
"-Daccumulo.local.hostname=$(hostname -s)")
    --- End diff --
    I'm not 100% sure off the top of my head, but shouldn't this be `hostname -f` for consistency
with what we had before? I like using the FQDN (the canonical name) to refer to nodes as a
general rule.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message