accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #220: ACCUMULO-4591 replication latency metrics added
Date Thu, 23 Feb 2017 21:19:25 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/220#discussion_r102820537
  
    --- Diff: server/master/src/main/java/org/apache/accumulo/master/metrics/Metrics2ReplicationMetrics.java
---
    @@ -58,6 +59,7 @@ protected void snapshot() {
         registry.add(PENDING_FILES, getNumFilesPendingReplication());
         registry.add(NUM_PEERS, getNumConfiguredPeers());
         registry.add(MAX_REPLICATION_THREADS, getMaxReplicationThreads());
    +    registry.add(LATENCY, getLatencyInSeconds());
    --- End diff --
    
    Ah, crap. It looks like I was confusing what exists in other Metrics libraries as primitives.
    
    Hadoop Metrics2 supports gauges, counters, stats and quantiles. You would want to create
`MutableQuantiles` and some `MutableGauges` from the `MetricsRegistry`. You can maintain the
min, median, avg, and max as gauges, and then present the percentiles using the quantiles.
Essentially, you'd have to track both separately. Like you have here, you could just instrument
this class to compute the current metrics instead of doing it "in-band" in `RCRR`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message