accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #220: ACCUMULO-4591 replication latency metrics added
Date Thu, 23 Feb 2017 19:59:54 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/220#discussion_r102804050
  
    --- Diff: server/master/src/main/java/org/apache/accumulo/master/metrics/Metrics2ReplicationMetrics.java
---
    @@ -58,6 +59,7 @@ protected void snapshot() {
         registry.add(PENDING_FILES, getNumFilesPendingReplication());
         registry.add(NUM_PEERS, getNumConfiguredPeers());
         registry.add(MAX_REPLICATION_THREADS, getMaxReplicationThreads());
    +    registry.add(LATENCY, getLatencyInSeconds());
    --- End diff --
    
    Yes, not saying that having the maximum isn't helpful, but it paints a very skewed picture.
    
    We have the primitives to collect and display metrics which paint a complete picture.
I really think that we should use them instead of only displaying the maximum.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message