accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <>
Subject [GitHub] accumulo pull request #220: ACCUMULO-4591 replication latency metrics added
Date Thu, 23 Feb 2017 19:47:18 GMT
Github user ctubbsii commented on a diff in the pull request:
    --- Diff: server/master/src/main/java/org/apache/accumulo/master/replication/
    @@ -216,4 +220,13 @@ protected long removeRowIfNecessary(BatchWriter bw, SortedMap<Key,Value>
         return recordsRemoved;
    +  /*
    +   * Metrics calls snapshot. Largest time stamp will be found for each snapshot then
    +   */
    +  private void collectLatency(Long createdTime) {
    +    long latency = System.currentTimeMillis() - createdTime;
    --- End diff --
    I guess... but there's really no reason to fudge when there's a built-in API for this
in the JVM. I realize we're still using currentTimeMillis elsewhere, but I'm trying to encourage
us to move away from that, for correctness.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message