accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #220: ACCUMULO-4591 replication latency metrics added
Date Thu, 23 Feb 2017 02:03:33 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/220#discussion_r102622870
  
    --- Diff: server/master/src/main/java/org/apache/accumulo/master/replication/RemoveCompleteReplicationRecords.java
---
    @@ -57,9 +58,11 @@
       private static final Logger log = LoggerFactory.getLogger(RemoveCompleteReplicationRecords.class);
     
       private Connector conn;
    +  private Master master;
     
    -  public RemoveCompleteReplicationRecords(Connector conn) {
    +  public RemoveCompleteReplicationRecords(Connector conn, Master master) {
    --- End diff --
    
    Is this connector for the remote peer? If not, the master actually contains a client context
and the connector is redundant if the master is being passed in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message