accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #218: ACCUMULO-4528 Accumulo scripts improvements
Date Wed, 15 Feb 2017 20:37:21 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/218#discussion_r101365020
  
    --- Diff: assemble/conf/examples/generic_logger.properties ---
    @@ -15,7 +15,7 @@
     
     # Write out everything at the DEBUG level to the debug log
     log4j.appender.A2=org.apache.log4j.RollingFileAppender
    -log4j.appender.A2.File=${org.apache.accumulo.core.dir.log}/${org.apache.accumulo.core.application}_${accumulo.service.instance}${org.apache.accumulo.core.ip.localhost.hostname}_fromprops.debug.log
    +log4j.appender.A2.File=${org.apache.accumulo.core.dir.log}/${org.apache.accumulo.core.application}${accumulo.service.instance}_${org.apache.accumulo.core.ip.localhost.hostname}_fromprops.debug.log
    --- End diff --
    
    Rather than produce these system properties in Accumulo code, we should use the log4j
feature to do `${sys:HOSTNAME}` (might be log4j2 only, but that's okay... we should switch
to that)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message