accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request #210: ACCUMULO-4577: modified exception thrown by Tabl...
Date Thu, 02 Feb 2017 21:13:25 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/210#discussion_r99219350
  
    --- Diff: server/master/src/main/java/org/apache/accumulo/master/MasterClientServiceHandler.java
---
    @@ -253,6 +253,16 @@ public void waitForFlush(TInfo tinfo, TCredentials c, String tableId,
ByteBuffer
     
       }
     
    +  private String getNamespaceId(TableOperation tableOp, String tableId) throws ThriftTableOperationException
{
    --- End diff --
    
     For consistency, could use the method name`getNamespaceIdFromTableId` like you did elsewhere.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message