accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From milleruntime <...@git.apache.org>
Subject [GitHub] accumulo pull request #210: ACCUMULO-4577: modified exception thrown by Tabl...
Date Thu, 02 Feb 2017 19:27:25 GMT
Github user milleruntime commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/210#discussion_r99198369
  
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/client/ClientServiceHandler.java
---
    @@ -194,10 +194,14 @@ public void grantSystemPermission(TInfo tinfo, TCredentials credentials,
String
       }
     
       @Override
    -  public void grantTablePermission(TInfo tinfo, TCredentials credentials, String user,
String tableName, byte permission) throws ThriftSecurityException,
    -      ThriftTableOperationException {
    +  public void grantTablePermission(TInfo tinfo, TCredentials credentials, String user,
String tableName, byte permission) throws TException {
         String tableId = checkTableId(instance, tableName, TableOperation.PERMISSION);
    -    String namespaceId = Tables.getNamespaceId(instance, tableId);
    +    String namespaceId;
    +    try {
    +      namespaceId = Tables.getNamespaceId(instance, tableId);
    +    } catch (TableNotFoundException e) {
    +      throw new TException(e);
    --- End diff --
    
    Good question, I am not sure.  I will try and test this case to see what gets printed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message