accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request #210: ACCUMULO-4577: modified exception thrown by Tabl...
Date Thu, 02 Feb 2017 18:37:23 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/210#discussion_r99188785
  
    --- Diff: server/master/src/main/java/org/apache/accumulo/master/tableOps/ExportTable.java
---
    @@ -27,12 +31,16 @@
     
       private final ExportInfo tableInfo;
     
    -  public ExportTable(String tableName, String tableId, String exportDir) {
    +  public ExportTable(String tableName, String tableId, String exportDir) throws ThriftTableOperationException
{
         tableInfo = new ExportInfo();
         tableInfo.tableName = tableName;
         tableInfo.exportDir = exportDir;
         tableInfo.tableID = tableId;
    -    tableInfo.namespaceID = Tables.getNamespaceId(HdfsZooInstance.getInstance(), tableId);
    +    try {
    --- End diff --
    
    Could refactor this to resolve the namespace id in FateServiceHandler (using the new method
in FateServiceHandler) and just pass the namespaceId to the constructor.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message