accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request #210: ACCUMULO-4577: modified exception thrown by Tabl...
Date Thu, 02 Feb 2017 18:15:02 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/210#discussion_r99184061
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java ---
    @@ -1320,9 +1356,9 @@ public void splitTablet(TInfo tinfo, TCredentials credentials, TKeyExtent
tkeyEx
           String namespaceId;
           try {
             namespaceId = Tables.getNamespaceId(getInstance(), tableId);
    -      } catch (IllegalArgumentException ex) {
    -        // table does not exist, try to educate the client
    -        throw new NotServingTabletException(tkeyExtent);
    +      } catch (TableNotFoundException ex) {
    +        // tableOperationsImpl catches ThriftSeccurityException and checks for missing
table
    +        throw new ThriftSecurityException(credentials.getPrincipal(), SecurityErrorCode.TABLE_DOESNT_EXIST);
    --- End diff --
    
    Why switch from NotServingTabletException to ThriftSecurityException?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message