accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request #209: ACCUMULO-4578 release namespace lock when compac...
Date Mon, 30 Jan 2017 18:10:42 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/209#discussion_r98503081
  
    --- Diff: fate/src/main/java/org/apache/accumulo/fate/AdminUtil.java ---
    @@ -110,25 +110,36 @@ public String getTop() {
       public static class FateStatus {
     
         private final List<TransactionStatus> transactions;
    -    private final Map<Long,List<String>> danglingHeldLocks;
    -    private final Map<Long,List<String>> danglingWaitingLocks;
    +    private final Map<String,List<String>> danglingHeldLocks;
    +    private final Map<String,List<String>> danglingWaitingLocks;
    +
    +    private static Map<String,List<String>> convert(Map<Long,List<String>>
danglocks) {
    +      if (danglocks.isEmpty()) {
    +        return Collections.emptyMap();
    +      }
    +
    +      Map<String,List<String>> ret = new HashMap<>();
    +      for (Entry<Long,List<String>> entry : danglocks.entrySet()) {
    +        ret.put(String.format("%016x", entry.getKey()), Collections.unmodifiableList(entry.getValue()));
    --- End diff --
    
    > It's not clear, for example, that this is just pre-formatting the object for future
logging.
    
    Oh, this code is not used by logging.   This code is only used by test and the shell.
 It uses the same formatting as the other code that does logging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message