accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From EdColeman <...@git.apache.org>
Subject [GitHub] accumulo pull request #207: ACCUMULO-4446 Making changes to 1.7
Date Mon, 30 Jan 2017 12:44:53 GMT
Github user EdColeman commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/207#discussion_r98433091
  
    --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/Monitor.java ---
    @@ -642,7 +643,7 @@ private void getMonitorLock() throws KeeperException, InterruptedException
{
           UtilWaitThread.sleep(getContext().getConfiguration().getTimeInMillis(Property.MONITOR_LOCK_CHECK_INTERVAL));
         }
     
    -    log.info("Got Monitor lock.");
    +    log.info("Acquired Monitor Lock " + monitorLock.getLockPath());
    --- End diff --
    
    Parameterized messages eliminate unnecessary object creation and we are moving to use
that throughout the code base.  Without the parameter format, monitor.getLockPath() is always
called, even if the log message will not be written. When passed as a parameter, the evaluation
is deferred until the log statement has been determined that the value is going to be used.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message