accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From EdColeman <...@git.apache.org>
Subject [GitHub] accumulo pull request #207: ACCUMULO-4446 Making changes to 1.7
Date Fri, 27 Jan 2017 03:19:53 GMT
Github user EdColeman commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/207#discussion_r98139545
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java ---
    @@ -2383,12 +2383,12 @@ public void run() {
           for (int i = 0; i < 120 / 5; i++) {
             zoo.putPersistentData(zPath, new byte[0], NodeExistsPolicy.SKIP);
     
    +        log.info("Attempting to acquire Tablet Server Lock");
             if (tabletServerLock.tryLock(lw, lockContent)) {
    -          log.debug("Obtained tablet server lock " + tabletServerLock.getLockPath());
    +          log.info("Acquired Tablet Server Lock " + tabletServerLock.getLockPath());
    --- End diff --
    
    Please consider using slf4j parameterized message format.
    
    ` log.info("Acquired Tablet Server Lock {}", tabletServerLock.getLockPath()); `


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message