accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo-testing pull request #2: ACCUMULO-4510 Refactored Continous Ingest ...
Date Wed, 25 Jan 2017 15:56:27 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo-testing/pull/2#discussion_r97806863
  
    --- Diff: core/src/main/java/org/apache/accumulo/testing/core/continuous/ContinuousIngest.java
---
    @@ -51,49 +46,44 @@
     
       private static List<ColumnVisibility> visibilities;
     
    -  private static void initVisibilities(ContinuousOpts opts) throws Exception {
    -    if (opts.visFile == null) {
    -      visibilities = Collections.singletonList(new ColumnVisibility());
    -      return;
    -    }
    -
    -    visibilities = new ArrayList<>();
    -
    -    FileSystem fs = FileSystem.get(new Configuration());
    -    BufferedReader in = new BufferedReader(new InputStreamReader(fs.open(new Path(opts.visFile)),
UTF_8));
    -
    -    String line;
    -
    -    while ((line = in.readLine()) != null) {
    -      visibilities.add(new ColumnVisibility(line));
    -    }
    -
    -    in.close();
    -  }
    -
       private static ColumnVisibility getVisibility(Random rand) {
         return visibilities.get(rand.nextInt(visibilities.size()));
       }
     
       public static void main(String[] args) throws Exception {
     
    -    ContinuousOpts opts = new ContinuousOpts();
    -    BatchWriterOpts bwOpts = new BatchWriterOpts();
    -    ClientOnDefaultTable clientOpts = new ClientOnDefaultTable("ci");
    -    clientOpts.parseArgs(ContinuousIngest.class.getName(), args, bwOpts, opts);
    +    if (args.length != 1) {
    +      System.err.println("Usage: ContinuousIngest <propsPath>");
    --- End diff --
    
    this is nice, replacing all of the command line options with a props file


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message