accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo-testing pull request #2: ACCUMULO-4510 Refactored Continous Ingest ...
Date Wed, 25 Jan 2017 15:56:27 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo-testing/pull/2#discussion_r97809185
  
    --- Diff: core/src/main/java/org/apache/accumulo/testing/core/continuous/ContinuousScanner.java
---
    @@ -20,49 +20,44 @@
     
     import java.util.Iterator;
     import java.util.Map.Entry;
    +import java.util.Properties;
     import java.util.Random;
     import java.util.concurrent.TimeUnit;
     
    -import org.apache.accumulo.core.cli.ClientOnDefaultTable;
    -import org.apache.accumulo.core.cli.ScannerOpts;
     import org.apache.accumulo.core.client.Connector;
     import org.apache.accumulo.core.client.Scanner;
     import org.apache.accumulo.core.data.Key;
     import org.apache.accumulo.core.data.Range;
     import org.apache.accumulo.core.data.Value;
     import org.apache.accumulo.core.security.Authorizations;
    +import org.apache.accumulo.testing.core.TestProps;
     import org.apache.hadoop.io.Text;
     
    -import com.beust.jcommander.Parameter;
    -import com.beust.jcommander.validators.PositiveInteger;
     import static com.google.common.util.concurrent.Uninterruptibles.sleepUninterruptibly;
     
     public class ContinuousScanner {
     
    -  static class Opts extends ContinuousWalk.Opts {
    -    @Parameter(names = "--numToScan", description = "Number rows to scan between sleeps",
required = true, validateWith = PositiveInteger.class)
    -    long numToScan = 0;
    -  }
    -
       public static void main(String[] args) throws Exception {
    -    Opts opts = new Opts();
    -    ScannerOpts scanOpts = new ScannerOpts();
    -    ClientOnDefaultTable clientOpts = new ClientOnDefaultTable("ci");
    -    clientOpts.parseArgs(ContinuousScanner.class.getName(), args, scanOpts, opts);
    +
    +    Properties props = TestProps.loadFromFile(args[0]);
    +    ContinuousEnv env = new ContinuousEnv(props);
    --- End diff --
    
    I like ContinuousEnv


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message