accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request #206: ACCUMULO-4575 Fixed concurrent delete table bug
Date Tue, 24 Jan 2017 23:50:33 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/206#discussion_r97680645
  
    --- Diff: minicluster/src/main/java/org/apache/accumulo/cluster/standalone/StandaloneAccumuloCluster.java
---
    @@ -184,4 +188,12 @@ public ClusterUser getUser(int offset) {
         checkArgument(offset >= 0 && offset < users.size(), "Invalid offset,
should be non-negative and less than " + users.size());
         return users.get(offset);
       }
    +
    +  @Override
    +  public AccumuloConfiguration getSiteConfiguration() {
    +    Configuration conf = new Configuration(false);
    +    Path accumuloSite = new Path(serverAccumuloConfDir, "accumulo-site.xml");
    --- End diff --
    
    I Am not sure what the current code will do in that case.  Personally I think it should
fail here, instead of later where it make it harder to debug the issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message