accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request #204: ACCUMULO-4574 Modified TableOperations online to...
Date Mon, 23 Jan 2017 15:54:32 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/204#discussion_r97337611
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java
---
    @@ -1209,6 +1209,15 @@ public void online(String tableName) throws AccumuloSecurityException,
AccumuloE
       public void online(String tableName, boolean wait) throws AccumuloSecurityException,
AccumuloException, TableNotFoundException {
         checkArgument(tableName != null, "tableName is null");
         String tableId = Tables.getTableId(context.getInstance(), tableName);
    +
    +    /**
    +     * ACCUMULO-4574 if table is already online return without executing fate operation.
    +     */
    +    TableState expectedState = Tables.getTableState(context.getInstance(), tableId);
    --- End diff --
    
    The implementation of this uses zoo cache.   So it may return stale information.  Before
getting the table state, could call `Tables.clearCache()`.  This will force the table state
to be read from zookeeper.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message