accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #200: Accumulo 4558 Added shell command to display ser...
Date Thu, 12 Jan 2017 14:41:21 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/200#discussion_r95804314
  
    --- Diff: shell/src/main/java/org/apache/accumulo/shell/commands/TabletServerStatusCommand.java
---
    @@ -0,0 +1,95 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.accumulo.shell.commands;
    +
    +import java.util.ArrayList;
    +import java.util.List;
    +
    +import org.apache.accumulo.core.client.TServerStatus;
    +import org.apache.accumulo.core.client.TabletServerNotFoundException;
    +import org.apache.accumulo.core.client.admin.InstanceOperations;
    +import org.apache.accumulo.shell.Shell;
    +import org.apache.accumulo.shell.Shell.Command;
    +import org.apache.commons.cli.CommandLine;
    +import org.apache.commons.cli.MissingOptionException;
    +import org.apache.commons.cli.Option;
    +import org.apache.commons.cli.Options;
    +
    +/**
    + *
    + */
    +public class TabletServerStatusCommand extends Command {
    +
    +  private Option tserverOption, disablePaginationOpt, allOption;
    +
    +  @Override
    +  public String description() {
    +    return "get tablet servers status, master server must be running";
    +  }
    +
    +  @Override
    +  public int execute(final String fullCommand, final CommandLine cl, final Shell shellState)
throws Exception {
    +    List<TServerStatus> tservers;
    +
    +    final InstanceOperations instanceOps = shellState.getConnector().instanceOperations();
    +
    +    final boolean paginate = !cl.hasOption(disablePaginationOpt.getOpt());
    +
    +    if (cl.hasOption(tserverOption.getOpt())) {
    +      tservers = new ArrayList<>();
    +      for (TServerStatus ts : instanceOps.getTabletServerStatus()) {
    +        if (ts.getName().equals(cl.getOptionValue(tserverOption.getOpt()))) {
    +          tservers.add(ts);
    +        }
    +      }
    +    } else if (cl.hasOption(allOption.getOpt())) {
    +      tservers = instanceOps.getTabletServerStatus();
    +    } else {
    +      throw new MissingOptionException("Missing options");
    +    }
    +
    +    if (tservers.isEmpty()) {
    +      throw new TabletServerNotFoundException("Tablet Servers not found");
    --- End diff --
    
    I don't think we need to throw an exception here. We can just print nothing, if there's
no status available.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message