accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #195: ACCUMULO-4446 Added log INFO when acquiring Moni...
Date Mon, 09 Jan 2017 17:57:25 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/195#discussion_r95208393
  
    --- Diff: server/master/src/main/java/org/apache/accumulo/master/Master.java ---
    @@ -1424,7 +1424,7 @@ private void getMasterLock(final String zMasterLoc) throws KeeperException,
Inte
     
           sleepUninterruptibly(TIME_TO_WAIT_BETWEEN_LOCK_CHECKS, TimeUnit.MILLISECONDS);
         }
    -
    +    log.info("Got Master lock.");
    --- End diff --
    
    Could make the wording consistent across all the services. I would use "Attempting to
acquire" and "Acquired". You can also drop the periods off the end of the log message. They
aren't complete sentences anyway.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message