accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo issue #195: ACCUMULO-4446 Added log INFO when acquiring Monitor loc...
Date Wed, 04 Jan 2017 16:54:54 GMT
Github user joshelser commented on the issue:

    https://github.com/apache/accumulo/pull/195
  
    I do want to say, I think we can do a bit better than just changing log messages.
    
    Accumulo is made up of many services, e.g. TabletServers, Masters, GCs. Many (if not all)
of these services acquire a ZooKeeper lock before they start. My original idea was that instead
of duplicating this logic across each service, we can have a common abstract class which encapsulates
the logic of acquiring a ZK lock and then starting the service. Then, we wouldn't have to
ask the question "Does service X have log messages around zk lock acquisition?", instead asking
"Does service X extend _LockAcquiringService_" or something.
    
    I think we'd be better off restructuring the code to remove the duplication. What you
have done here is fine, just wanted to describe where I could see this going in the future
(if you're interested in looking into that too).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message