Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: joshelser <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-194-accumulo@git.apache.org>
In-Reply-To: <git-pr-194-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #194: ACCUMULO-3005 Added REST API calls
Content-Type: text/plain
Message-Id: <20161224182331.18A29DFCC5@git1-us-west.apache.org>
Date: Sat, 24 Dec 2016 18:23:31 +0000 (UTC)
archived-at: Sat, 24 Dec 2016 18:23:34 -0000

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/194#discussion_r93819874
  
    --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/resources/GarbageCollectorResource.java ---
    @@ -0,0 +1,101 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.accumulo.monitor.rest.resources;
    +
    +import javax.ws.rs.GET;
    +import javax.ws.rs.Path;
    +import javax.ws.rs.Produces;
    +import javax.ws.rs.core.MediaType;
    +
    +import org.apache.accumulo.core.gc.thrift.GCStatus;
    +import org.apache.accumulo.monitor.Monitor;
    +import org.apache.accumulo.monitor.rest.api.GarbageCollection;
    +import org.apache.accumulo.monitor.rest.api.GarbageCollectorCycle;
    +import org.apache.accumulo.monitor.rest.api.GarbageCollectorStatus;
    +
    +/**
    + * GarbageCollector metrics
    + */
    +@Path("/gc")
    +@Produces({MediaType.APPLICATION_JSON, MediaType.APPLICATION_XML})
    +public class GarbageCollectorResource {
    +
    +  @GET
    --- End diff --
    
    I think the `@GET` could be lifted to the class-level and it would be implied on each method to remove some duplication.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---