accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #195: ACCUMULO-4446 Added log INFO when acquiring Moni...
Date Thu, 29 Dec 2016 20:16:47 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/195#discussion_r94175907
  
    --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/Monitor.java ---
    @@ -647,6 +648,7 @@ private void getMonitorLock() throws KeeperException, InterruptedException
{
           }
     
           if (!monitorLockWatcher.failedToAcquireLock) {
    +        log.warn("Failed to acquire Monitor lock. Monitor lock is in unknown state.");
    --- End diff --
    
    IMO, this isn't adding any value. The thrown unchecked exception is already propagating
what the log message says. As an operator, if I saw that exception logged, the log message
wouldn't tell me anything else about what went wrong or how to fix it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message