accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lstav <...@git.apache.org>
Subject [GitHub] accumulo pull request #194: ACCUMULO-3005 Added REST API calls
Date Tue, 27 Dec 2016 13:11:16 GMT
Github user lstav commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/194#discussion_r93929503
  
    --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/api/AllTimeTabletResults.java
---
    @@ -0,0 +1,39 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.accumulo.monitor.rest.api;
    +
    +public class AllTimeTabletResults {
    +
    +  public String operation;
    --- End diff --
    
    @ctubbsii and I discussed about using the `public` variable vs `private` with setters
and getters, and we decided to use `public` variables, with the plus that it decreases the
number of lines it takes to write each call. I was following what you had with `private` variables
at first before talking with @ctubbsii, is there a reason we shouldn't go with `public` variables?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message