accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #192: ACCUMULO-4534 Disable external entities in SAX p...
Date Sun, 11 Dec 2016 19:47:23 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/192#discussion_r91863571
  
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/util/RestoreZookeeper.java
---
    @@ -118,6 +118,9 @@ public static void main(String[] args) throws Exception {
         }
     
         SAXParserFactory factory = SAXParserFactory.newInstance();
    +    factory.setFeature("http://xml.org/sax/features/external-general-entities", false);
    +    factory.setFeature("http://xml.org/sax/features/external-parameter-entities", false);
    +    factory.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd",
false);
    --- End diff --
    
    > So, I would just do the following instead of anything more complicated or speculative
with respect to a particular parser:
    
    Fantastic. This is exactly the kind of answer I was expecting to hear from you :)
    
    > But, this tool is typically run in the same security context as the user... and not
by a remote service, so there really isn't a vulnerability out-of-the-box anyway.
    
    Agreed. That's why I didn't go the route of private file+fix+announce. It's a nice thing
we can do to make sure users don't do anything "dumb", but it's not a vulnerability in the
traditional sense of XEE.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message