Return-Path: <dev-return-16716-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 8C730200BC2
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu, 17 Nov 2016 21:55:15 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 8AD52160B0B; Thu, 17 Nov 2016 20:55:15 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 07B8F160AD8
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 17 Nov 2016 21:55:14 +0100 (CET)
Received: (qmail 88279 invoked by uid 500); 17 Nov 2016 20:55:14 -0000
Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@accumulo.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@accumulo.apache.org>
List-Post: <mailto:dev@accumulo.apache.org>
List-Id: <dev.accumulo.apache.org>
Reply-To: dev@accumulo.apache.org
Delivered-To: mailing list dev@accumulo.apache.org
Received: (qmail 88268 invoked by uid 99); 17 Nov 2016 20:55:13 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Nov 2016 20:55:13 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id D1107E0FC4; Thu, 17 Nov 2016 20:55:13 +0000 (UTC)
From: joshelser <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-159-accumulo@git.apache.org>
In-Reply-To: <git-pr-159-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #159: ACCUMULO-1280: many changes for closing iterator...
Content-Type: text/plain
Message-Id: <20161117205513.D1107E0FC4@git1-us-west.apache.org>
Date: Thu, 17 Nov 2016 20:55:13 +0000 (UTC)
archived-at: Thu, 17 Nov 2016 20:55:15 -0000

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/159#discussion_r88543835
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/iterators/SortedKeyValueIterator.java ---
    @@ -147,4 +147,13 @@
        *              if not supported.
        */
       SortedKeyValueIterator<K,V> deepCopy(IteratorEnvironment env);
    +
    +  /**
    +   * Closes the Iterator. This should be overridden by the implementing class that has access to <tt>SortedKeyValueIterator source</tt> provided in the
    --- End diff --
    
    Thanks for the rewording, Mike. I'm still left with an ambiguous feeling after reading it.
    
    * Would recommend not using words like "Typically". If an SKVI's `source` should be closed in the `close()` method, be explicit. This also makes me wonder, are these semantics `SHOULD` or `MUST`? What happens to an SKVI I have which doesn't implement close?
    * Exceptional cases are still not covered. Should implementations of `close()` eat exceptions or propagate them as RuntimeExceptions?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---