accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mjwall <...@git.apache.org>
Subject [GitHub] accumulo pull request #180: Taking a crack at new summarization API
Date Thu, 10 Nov 2016 20:29:56 GMT
Github user mjwall commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/180#discussion_r87479084
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/summary/ColumnVisibilitySummarizer.java
---
    @@ -0,0 +1,91 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.accumulo.core.client.summary;
    +
    +import java.util.HashMap;
    +import java.util.Map;
    +
    +import org.apache.accumulo.core.data.ByteSequence;
    +import org.apache.accumulo.core.data.Key;
    +import org.apache.accumulo.core.data.Value;
    +import org.apache.commons.lang.mutable.MutableLong;
    +
    +public class ColumnVisibilitySummarizer implements KeyValueSummarizer {
    +
    +  private static final int MAX = 5000;
    +  private static final String PREFIX = "cv:";
    +  private static final String IGNORE_KEY = "ignored";
    +
    +  // Map used for computing summary incrementally uses ByteSequence for key which is
more efficient than converting colvis to String for each Key. The
    +  // conversion to String is deferred until the summary is requested.  This shows how
the interface enables users to write efficient summarizers.
    +  private Map<ByteSequence,MutableLong> summary = new HashMap<>();
    +  private long ignored = 0;
    +
    +  @Override
    +  public String getId() {
    +    return "accumulo.cvsummary";
    +  }
    +
    +  @Override
    +  public void collect(Key k, Value v) {
    --- End diff --
    
    Is this the function that would be used when an rfile is compacted to aggregate the counts.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message