accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #178: ACCUMULO-4505: Fix for Shell erroneously reading...
Date Fri, 04 Nov 2016 23:03:27 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/178#discussion_r86646752
  
    --- Diff: shell/src/main/java/org/apache/accumulo/shell/Shell.java ---
    @@ -492,7 +491,8 @@ private static Instance getZooInstance(String instanceName, String
keepersOption
         if (instanceName == null) {
           instanceName = clientConfig.get(ClientProperty.INSTANCE_NAME);
         }
    -    AccumuloConfiguration conf = SiteConfiguration.getInstance(ClientContext.convertClientConfig(clientConfig));
    +    // ACCUMULO-4505: Fix to use ClientConfig since it should have everything we need
    --- End diff --
    
    nit: Comment may not make sense outside the context of the diff.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message