accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #160: ACCUMULO-4490: Simplify Accumulo scripts and con...
Date Thu, 03 Nov 2016 21:51:46 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/160#discussion_r86451237
  
    --- Diff: test/system/upgrade_test.sh ---
    @@ -65,13 +65,13 @@ echo "compact -t test_ingest -w" | $CURR/bin/accumulo shell -u root
-p secret
     echo "compact -t test_ingest -w" | $CURR/bin/accumulo shell -u root -p secret
     "$CURR/bin/accumulo" org.apache.accumulo.test.VerifyIngest --size 50 --timestamp 2 --random
57 --rows 500000 --start 0 --cols 1 -i $INSTANCE -u root -p secret
     
    -"$CURR/bin/stop-all.sh"
    -"$CURR/bin/start-all.sh"
    +"$CURR/bin/accumulo-cluster stop"
    +"$CURR/bin/accumulo-cluster start"
     
     "$CURR/bin/accumulo" org.apache.accumulo.test.VerifyIngest --size 50 --timestamp 2 --random
57 --rows 500000 --start 0 --cols 1 -i $INSTANCE -u root -p secret
     
     pkill -9 -f accumulo.start
    -"$CURR/bin/start-all.sh"
    +"$CURR/bin/accumulo-cluster start"
    --- End diff --
    
    I think the quoting here is wrong. Start is the first arg. Only the first part needs to
be quoted (actually, only `$CURR` needs it, but doesn't hurt to include the full path to the
script).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message