Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: joshelser <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-160-accumulo@git.apache.org>
In-Reply-To: <git-pr-160-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #160: Simplify Accumulo scripts and config files
Content-Type: text/plain
Message-Id: <20161010023530.1B362E0209@git1-us-west.apache.org>
Date: Mon, 10 Oct 2016 02:35:30 +0000 (UTC)
archived-at: Mon, 10 Oct 2016 02:35:32 -0000

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/160#discussion_r82539018
  
    --- Diff: assemble/bin/accumulo-single ---
    @@ -0,0 +1,80 @@
    +#! /usr/bin/env bash
    +
    +# Licensed to the Apache Software Foundation (ASF) under one or more
    +# contributor license agreements.  See the NOTICE file distributed with
    +# this work for additional information regarding copyright ownership.
    +# The ASF licenses this file to You under the Apache License, Version 2.0
    +# (the "License"); you may not use this file except in compliance with
    +# the License.  You may obtain a copy of the License at
    +#
    +#     http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    +
    +# Start: Resolve Script Directory
    +SOURCE="${BASH_SOURCE[0]}"
    +while [ -h "${SOURCE}" ]; do # resolve $SOURCE until the file is no longer a symlink
    +   bin="$( cd -P "$( dirname "${SOURCE}" )" && pwd )"
    +   SOURCE="$(readlink "${SOURCE}")"
    +   [[ "${SOURCE}" != /* ]] && SOURCE="${bin}/${SOURCE}" # if $SOURCE was a relative symlink, we need to resolve it relative to the path where the symlink file was located
    +done
    +bin="$( cd -P "$( dirname "${SOURCE}" )" && pwd )"
    +# Stop: Resolve Script Directory
    +
    +function print_usage {
    +  echo "Usage: accumulo-single <command>"
    +  echo
    +  echo "Commands:"
    +  echo "  start     Starts Accumulo on a single node"
    +  echo "  stop      Stops Accumulo on a single node"
    +  echo
    +  exit 1
    +}
    +
    +function invalid_args {
    +  echo -e "Invalid arguments: $1\n"
    +  print_usage
    +  exit 1
    +}
    +
    +function main() {
    +  scripts=${bin}/../scripts
    +
    +  if [[ -z $1 ]]; then
    +    invalid_args "<command> cannot be empty"
    +  fi
    +
    +  case "$1" in
    +    start)
    +      "${bin}"/accumulo-service monitor start
    +      "${bin}"/accumulo-service tserver start
    +      "${bin}"/accumulo exec org.apache.accumulo.master.state.SetGoalState NORMAL
    +      "${bin}"/accumulo-service master start
    +      "${bin}"/accumulo-service gc start
    +      "${bin}"/accumulo-service tracer start
    +      ;;
    +    stop)
    +      "${bin}"/accumulo-service monitor stop
    +      "${bin}"/accumulo-service master stop
    --- End diff --
    
    Aren't we missing a SetGoalState CLEAN_STOP or SAFE_MODE here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---