accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mikewalch <...@git.apache.org>
Subject [GitHub] accumulo pull request #175: Accumulo 1480 Added namespace filtering to table...
Date Mon, 31 Oct 2016 16:36:37 GMT
Github user mikewalch commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/175#discussion_r85778016
  
    --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/util/Table.java ---
    @@ -227,4 +247,25 @@ private static void row(StringBuilder sb, boolean highlight, ArrayList<TableColu
         sb.append("</tr>\n");
       }
     
    +  private static void doDropdownMenu(String redir, String page, String tableName, StringBuilder
sb, SortedMap<String,String> namespaces, String namespace) {
    +
    +    String namespaceUrl = String.format("/op?action=namespace&redir=%s&page=%s&table=%s&selected=",
redir, page, tableName);
    +
    +    sb.append("<ul id=\"namespaces\">\n");
    +    sb.append("<li><a ").append(namespace.equals("*") ? "class=\"active\" "
: "").append("href=\"").append(namespaceUrl).append("*\">*</a></li>");
    +    for (String key : namespaces.keySet()) {
    +      if (key.equals("")) {
    +        sb.append("<li><a ").append(namespace.equals("-") ? "class=\"active\"
" : "").append("href=\"").append(namespaceUrl).append("-\">-</a></li>");
    --- End diff --
    
    Same as above. `-` is a little confusing.  Could add text describing this option as default
tables.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message