accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #160: ACCUMULO-4490: Simplify Accumulo scripts and con...
Date Wed, 26 Oct 2016 22:26:44 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/160#discussion_r85227434
  
    --- Diff: docs/src/main/asciidoc/chapters/iterator_design.txt ---
    @@ -37,8 +37,8 @@ pitfalls.
     
     To invoke an Accumulo Iterator inside of the TabletServer, the Iterator class must be
on the classpath of every
     TabletServer. For production environments, it is common to place a JAR file which contains
the Iterator in
    -`$ACCUMULO_HOME/lib`.  In development environments, it is convenient to instead place
the JAR file in
    -`$ACCUMULO_HOME/lib/ext` as JAR files in this directory are dynamically reloaded by the
TabletServers alleviating the
    +`$ACCUMULO_LIB_DIR`.  In development environments, it is convenient to instead place
the JAR file in
    --- End diff --
    
    I don't really find this more convenient or flexible than the old way. I think it's fine
to have a predictable directory layout convention. The less reliant we are on these environment
variables, the better, and I think that's easier to do if we don't make more of them. If we
do have scripts (such as the cluster scripts) rely on environment variables, I think it's
better to make them dependent on fewer of them, essentially minimizing the API for that script.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message