accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From milleruntime <...@git.apache.org>
Subject [GitHub] accumulo pull request #159: ACCUMULO-1280: many changes for closing iterator...
Date Tue, 25 Oct 2016 12:18:24 GMT
Github user milleruntime commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/159#discussion_r84888602
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanDataSource.java
---
    @@ -225,10 +225,18 @@ void close(boolean sawErrors) {
           fileManager = null;
         }
     
    -    if (statsIterator != null) {
    -      statsIterator.report();
    -    }
    +    try {
    +      if (statsIterator != null) {
    +        statsIterator.report();
    +        statsIterator.close();
    +      }
     
    +      if (iter != null) {
    +        iter.close();
    +      }
    +    } catch (Exception e) {
    +      throw new IOException(e);
    --- End diff --
    
    fixed in 93d86ceecef6f21eba8f60f7b6bdc29b43c1f83e


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message