accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request #159: ACCUMULO-1280: many changes for closing iterator...
Date Mon, 24 Oct 2016 21:13:59 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/159#discussion_r84778064
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/iterators/system/SourceSwitchingIterator.java
---
    @@ -162,6 +162,10 @@ private void readNext(boolean initialSeek) throws IOException {
       private boolean switchSource() throws IOException {
         if (!source.isCurrent()) {
           source = source.getNewDataSource();
    +      // if our source actually changed, then attempt to close the previous iterator
    +      if (iter != null) {
    --- End diff --
    
    SourceSwitchingIterator has a unit test.  It would be really nice to add a test to check
that iterators are closed when it switches sources.  I can help write this test if you would
like, just let me know.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message