accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <>
Subject [GitHub] accumulo pull request #159: ACCUMULO-1280: many changes for closing iterator...
Date Mon, 24 Oct 2016 21:13:59 GMT
Github user keith-turner commented on a diff in the pull request:
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/util/ ---
    @@ -361,6 +369,9 @@ public static double estimatePercentageLTE(VolumeManager fs, AccumuloConfigurati
           return ret;
         } finally {
    +      if (mmfi != null) {
    --- End diff --
    Would be better to move these lines after `cleanupIndexOp` ... or wrap with try+catch+log
so that cleanupIndexOp can still run

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message