accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request #159: ACCUMULO-1280: many changes for closing iterator...
Date Mon, 24 Oct 2016 21:13:59 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/159#discussion_r84768859
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java ---
    @@ -614,12 +614,15 @@ public DataSource getNewDataSource() {
     
           if (!isCurrent()) {
             switched = true;
    -        iter = null;
             try {
    +          if (iter != null) {
    +            iter.close();
    +          }
    +          iter = null;
               // ensure files are referenced even if iterator was never seeked before
               iterator();
    -        } catch (IOException e) {
    -          throw new RuntimeException();
    +        } catch (Exception e) {
    +          throw new RuntimeException(e);
    --- End diff --
    
    I think this can be changed to :
    
    ```java
    } catch (IOException e) {
      throw new UncheckedIOException(e)
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message