accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From milleruntime <...@git.apache.org>
Subject [GitHub] accumulo pull request #159: ACCUMULO-1280: many changes for closing iterator...
Date Mon, 24 Oct 2016 18:38:13 GMT
Github user milleruntime commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/159#discussion_r84754335
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/iterators/system/SourceSwitchingIterator.java
---
    @@ -162,6 +162,14 @@ private void readNext(boolean initialSeek) throws IOException {
       private boolean switchSource() throws IOException {
         if (!source.isCurrent()) {
           source = source.getNewDataSource();
    +      // if our source actually changed, then attempt to close the previous iterator
    +      try {
    +        if (iter != null) {
    +          iter.close();
    +        }
    +      } catch (Exception e) {
    +        throw new IOException(e);
    --- End diff --
    
    Fixed in ce0bd48fb8daa7eeed384d61cf7982ff49863275


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message